Skip to content

#1055 Install the Arduino_BuiltIn to built-in location #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

kittaakos
Copy link
Contributor

Motivation

Use a dedicated install location for the Arduino_BuiltIn lib on the first IDE2 start.

Change description

From now on, the built-in lib will be installed into the built-in location of the CLI.

Closes #1055.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: fixed by arduino/arduino-cli@fb57a52

Describe the problem

"built-in" libraries installation fails.

To reproduce

  1. Select File > Quit from the Arduino IDE menus if it is running.
  2. Delete the "User Data Folder" to adequately simulate a fresh install.
    • Windows:
      C:\Users\<user name>\AppData\Roaming\arduino-ide
      
    • Linux:
      ~/.config/arduino-ide
      
    • macOS:
      ~/Library/Application Support/arduino-ide
      
  3. Start the Arduino IDE

🐛 The "built-in" libraries installation fails:

Failed to install library: Arduino_BuiltIn:1.0.0.
Error: 2 UNKNOWN: Builtin libraries directory not set

Expected behavior

Arduino IDE automatically configures Arduino CLI for the built-in libraries installation.

Arduino IDE version

2.0.0-rc9.2.snapshot-8bb5c61 (tester build for 092ca2d)

Operating system

Windows

Operating system version

10

Additional context

The required directories.builtin.libraries configuration key is not present in ~/.arduinoIDE/arduino-cli.yaml.

https://github.com/cmaglie/arduino-cli/blob/byebye_bundles/docs/configuration.md#configuration-keys

@per1234 per1234 added the topic: code Related to content of the project itself label Aug 31, 2022
@kittaakos kittaakos added type: enhancement Proposed improvement topic: CLI Related to Arduino CLI labels Aug 31, 2022
@kittaakos kittaakos changed the title Install the Arduino_BuiltIn to built-in location #1055 Install the Arduino_BuiltIn to built-in location Aug 31, 2022
Copy link
Contributor

@davegarthsimpson davegarthsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working perfectly now.

I verified that this change will align the behavior of the Arduino IDE 2.x "built-in" libraries with that of Arduino IDE 1.x, where they will have a lower "location priority" than platform bundled libraries.

Thanks Akos!

@kittaakos
Copy link
Contributor Author

Thank you for the review.

On-hold until arduino/arduino-cli#1817 is merged.

@kittaakos kittaakos added the status: on hold Do not proceed at this time label Aug 31, 2022
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos removed the status: on hold Do not proceed at this time label Sep 2, 2022
@kittaakos kittaakos merged commit 20cc34c into main Sep 2, 2022
@kittaakos kittaakos deleted the #1055 branch September 2, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dedicated location for "built-in" libraries
3 participants