Skip to content

#1327 Show all network and serial ports #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

#1327 Show all network and serial ports #1332

merged 2 commits into from
Aug 18, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

Removed the filtering of unrecognized network boards. Unrecognized network boards should show up with their IP addresses.

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Akos Kitta added 2 commits August 17, 2022 14:52
Fixed typos.
b649267 
Signed-off-by: Akos Kitta <[email protected]>
Show all network and serial ports.
8a413bc 
Otherwise, unrecognized network boards are ignored
by IDE2.

Closes #1327

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 17, 2022
per1234
per1234 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1327

Thanks Akos!

@kittaakos kittaakos mentioned this pull request Aug 18, 2022
Open
3 tasks
@kittaakos kittaakos merged commit 79ea0fa into main Aug 18, 2022
@kittaakos kittaakos deleted the #1327-signed branch August 18, 2022 09:03
@per1234 per1234 linked an issue Aug 23, 2022 that may be closed by this pull request
network boards not shown in board selector dropdown #1327
Closed
3 tasks
This was referenced Aug 28, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

network boards not shown in board selector dropdown
2 participants
@kittaakos @per1234