#411 Fixed bug when saving sketch as. Made native file dialogs modal.

[kittaakos]

Motivation

This PR is the outcome of the investigation of #411. This PR fixes the default location when saving a sketch as. From now on, every native file dialog is modal.

Change description

Noteworthy changes:

• If the sketch is temp, the default save location is directories/user/sketch_$current_date,

save_as__temp.mp4

• If a sketch is contained in the default location as directories/user/sketch, then the default location will be directories/user/sketch_copy_date,

save_as__in_sketchbook.mp4

• If a sketch is outside of the sketchbook, then the default location will be directories/user/sketch_$current_date,

save_as__outside_sketchbook.mp4

• If the sketch is in a nested folder in the sketchbook, then the default location will be directories/user/nested/location/sketch_$current_date.

save_as__nested_in_sketchbook.mp4

Other information

I could not reproduce the defect described here and here.

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[per1234]

It is working fine for me on both Windows and Linux. However, some things were not clear to me:

fixes the default location when saving a sketch as

What was the bug @kittaakos? Was it that the IDE did not follow this behavior?:

If the sketch is in a nested folder in the sketchbook, then the default location will be directories/user/nested/location/sketch_$current_date.

That was the only difference I noticed related to default Save as location when comparing the build from this PR to the latest one from the main branch.

I could not reproduce the defect described #411 (comment) and #411 (comment).

Closes #411.

It is not clear to me how it is considered as fixing #411 Would you mind providing more information about how the changes made in this PR are related to that issue?

[davegarthsimpson]

Code-wise approved.

[per1234]

I am also willing to approve this (though I would like to give it another try after a rebase).

I only wanted to make sure I fully understand the intention and context so that I would not omit an important "assertion" in my manual testing.

[kittaakos]

It is working fine for me on both Windows and Linux. However, some things were not clear to me:

fixes the default location when saving a sketch as

What was the bug @kittaakos? Was it that the IDE did not follow this behavior?:

Yes. If there is a sketch under #directories/user/nested_folder/my_sketch and the user tries to perform a Save As..., the #directories/user/my_sketch will be the default save as location.

IDE 2.0.0:

default_save_as_location_2.0.0.mp4

With the fix, the #directories/user/nested_folder/my_sketch_copy_$TIMESTAMP will be proposed.

IDE from PR:

default_save_as_location_PR.mp4

The other change is the use of modal dialogs in IDE2.

Please review. Thank you!

[per1234]

I verified again that the switch to modal file dialogs and more convenient default "Save As" location works correctly on both Windows and Linux.

Thanks Akos!