Set XDG_CONFIG_HOME env on Linux when not set.
#1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, `node-log-rotate` creates a folder with `undefined` name. Closes #394. Signed-off-by: Akos Kitta <[email protected]>
kittaakos
added
topic: code
kittaakos
commented
Aug 4, 2022
| @@ -1,4 +1,18 @@ | |||
| // @ts-check | |||
|
|
|||
| // Patch for on Linux when `XDG_CONFIG_HOME` is not available, `node-log-rotate` creates the folder with `undefined` name. | |||
umbynos
approved these changes
Aug 4, 2022
|
This seems to be solved. The log are created now under |
|
Great news, thank you for the verification. I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Set the
XDG_CONFIG_HOMEenv on Linux when not set. Otherwise,node-log-rotatecreates a folder with theundefinedname.Change description
Patched the patched
main.jsfor the Theia backend. 🤦Other information
Closes #394.
Reviewer checklist