Skip to content

use variable for step button container bkgnd #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

use variable for step button container bkgnd #1233

merged 1 commit into from
Jul 20, 2022

Conversation

davegarthsimpson
Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Jul 20, 2022 •
edited
Loading

Motivation

Hard coded color was used in stepper styling, hence mismatch with dark theme.

Change description

Uses a variable instead of a hard coded color. A typo width property has also been removed.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

francescospissu
francescospissu approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@davegarthsimpson davegarthsimpson removed the request for review from AlbyIanna July 20, 2022 12:56
@davegarthsimpson davegarthsimpson merged commit 71d5a15 into main Jul 20, 2022
@davegarthsimpson davegarthsimpson deleted the cleanup-stepper-styling branch July 20, 2022 12:56
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescospissu francescospissu francescospissu approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davegarthsimpson @francescospissu @per1234