Skip to content

Toolbar debug button #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

Toolbar debug button #1215

merged 1 commit into from
Jul 19, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

The debug button should be present in the toolbar.

Change description

Restore the previous button.

Enabled:
Screenshot 2022-07-19 114038

Disabled:
Screenshot 2022-07-19 114116

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 19, 2022
ubidefeo
ubidefeo reviewed Jul 19, 2022
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality on Arduino Zero and a few switch back and forth between that and non enabled boards to see the button disabling/enabling.

LGTM

per1234
per1234 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works exactly as expected for me.

Thanks Francesco!

@francescospissu francescospissu merged commit 119dfa7 into main Jul 19, 2022
@francescospissu francescospissu deleted the restore-debug-toolbar-button branch July 19, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@per1234 per1234 per1234 approved these changes

@fstasi fstasi Awaiting requested review from fstasi

@91volt 91volt Awaiting requested review from 91volt

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francescospissu @ubidefeo @per1234