Restart discovery after re-initializing client.

[kittaakos]

Motivation

Before #1132 the core gRPC client was not re-initialized (InitRequest) after the indexes update. Hence; the CLI could not provide up-to-date core search results to the IDE2. Now, it is working in IDE2 but after the core gRPC re-initialization, the board discovery (BoardListWatchRequest) is non-functional. This PR fixes it by sending out an event after the core client re-initialization so that the board discovery can restart in IDE2.

From here:

The Rescan gRPC function has been removed completely in favour of Init.

UpdateIndex and UpdateLibrariesIndex gRPC functions now don't implicitly reload the indexes, it has to be done explicitly with the Init function.

How to test:

• start IDE2,
• make sure you have at least one 3rd party URL in the Settings,
• after the indexes update progress notification, try to attach and detach boards, the IDE2 should show the attached boards. This is not working on the main with f4a68e7.

Change description

Other information

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[kittaakos]

For reviewers:

I am optimistic this PR should fix the discovery issue. At least, the nightly (f4a68e7) is broken here, the build from the PR works. Here is another way to verify. Connect at least one board to the machine before starting the IDE2. IDE2 starts, it's up and running, and shows the attached board(s). Wait for the indexes update, then detach the boards. IDE2 does not show the board changes from the nightly build. It works from this PR.

[AlbyIanna]

The code looks fine with me.
LGTM 🚀

[per1234]

UPDATE: fixed when using the build for e9cd290

I don't have a proper report prepared yet, but wanted to give a quick status update: Unfortunately, this does not fix the discovery issue for me on my Windows machine (it does work on my Linux machine). I will investigate further and provide full details as soon as possible.

[kittaakos]

Unfortunately, this does not fix the discovery issue for me on my Windows machine

I can also see a defect on my Windows machine.

I will investigate further and provide full details as soon as possible.

Thank you! Do not spend too much time with it, the discovery also bogus on this slower Windows machine.

[kittaakos]

• IDE2 starts,
• Index update runs, finishes,
• I plug in a MKR1000, and I see this in the logs:

daemon INFO {"level":"info","msg":"boards watcher interrupted by client","time":"2022-07-11T18:25:38+02:00"}

Nothing else happens. IDE2 does not recognize the board.

[per1234]

I am able to reproduce the bug this PR addresses when using the latest build from the main branch (7fed8fe).

Using the build from this PR, the discovery works extremely reliably. I was able to reproduce the issue reported at #1181 (comment), but very rarely even though I was specifically producing the conditions it occurs under.

So I would be satisfied with this fix even without the addition of the change proposed in #1181

[kittaakos]

As discussed, I am merging this PR and will open a follow-up described in #1181. Also, I'll put #1181 on hold.