Skip to content

Window min size #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2022
Merged

Window min size #1151

merged 3 commits into from
Jul 7, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

The current window minimum size is too low, we want to increase it.

Change description

  • set the minWidth and minHeight when opening a new window (note that I also set useContentSize to true to ensure the top bar of the OS is not included in the minHeight
  • changes the style of the dialogs to ensure the UI doesn't glitch when the user resizes the window

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added the topic: code Related to content of the project itself label Jul 7, 2022
fstasi
fstasi approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, works as expected

@AlbyIanna AlbyIanna merged commit 69d7e8e into main Jul 7, 2022
@AlbyIanna AlbyIanna deleted the window-min-size branch July 7, 2022 14:14
@per1234 per1234 mentioned this pull request Jul 8, 2022
Closed
@per1234 per1234 linked an issue Jul 8, 2022 that may be closed by this pull request
The layout of the main toolbar items (toggle pro-mode, serial monitor) is broken #129
Closed
@per1234 per1234 mentioned this pull request Jul 8, 2022
Closed
@per1234 per1234 linked an issue Jul 8, 2022 that may be closed by this pull request
Parts of the UI disappear when window is to small #662
Closed
@per1234 per1234 mentioned this pull request Jul 8, 2022
Closed
@per1234 per1234 linked an issue Jul 8, 2022 that may be closed by this pull request
Top of window truncated on panel auto resize with small window height #779
Closed
@per1234 per1234 mentioned this pull request Oct 3, 2022
Closed
3 tasks
@r3inbowari r3inbowari mentioned this pull request Oct 4, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos left review comments

@fstasi fstasi fstasi approved these changes

@per1234 per1234 Awaiting requested review from per1234

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
4 participants
@AlbyIanna @kittaakos @fstasi @per1234