Skip to content

Update buttons style #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 8, 2022
Merged

Update buttons style #1122

merged 11 commits into from
Jul 8, 2022

Conversation

francescospissu
Copy link
Contributor

Motivation

Buttons need to be updated to reflect the design system.

Change description

Changed the style of the buttons via CSS and and other minor changes.

Other information

Currently some colors do not reflect the design system because the related variables are not yet available. This PR cannot be merged until the variables are ready.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu linked an issue Jun 28, 2022 that may be closed by this pull request
@francescospissu francescospissu added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project type: enhancement Proposed improvement and removed type: imperfection Perceived defect in any part of project labels Jun 28, 2022
@per1234 per1234 added the status: blocked Progress on this prevented by an external cause label Jun 28, 2022
@francescospissu francescospissu force-pushed the fspissu/update-buttons-style branch 2 times, most recently from 8e2b21e to 7dfc762 Compare July 5, 2022 12:32
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

font-family: 'Open Sans';
font-style: normal;
font-weight: 300;
src: url(https://fonts.gstatic.com/s/opensans/v29/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0B4gaVI.woff2) format('woff2');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have it at build time instead of fetching it. Or how does this work? 😊 Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it taking into account how something like this is already implemented here:

@font-face {
font-family: 'FontAwesome';
src:
url('fonts/FontAwesome.ttf?nuchcq') format('truetype'),
url('fonts/FontAwesome.woff?nuchcq') format('woff'),
url('fonts/FontAwesome.svg?nuchcq#FontAwesome') format('svg');
font-weight: normal;
font-style: normal;
font-display: block;
}

I'll investigate how to add it at compile time. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francescospissu I think Akos comment was related to the fact that
src: url(https://fonts.gstatic.com/s/opensans/v29/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0B4gaVI.woff2) format('woff2'); will not work without internet connection. (see the HTTP fetch)

while url('fonts/FontAwesome.woff?nuchcq') format('woff') does, as the font is in the source files.

I agree we should avoid the fetch if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the Open Sans font file in the fonts folder, here.
In this way we can avoid the fetch.

@91volt
Copy link

91volt commented Jul 7, 2022

@francescospissu Great work, we are almost there in term of adherence to the design, some fixes:

  • The font weight is 600
  • the vertical alignment needs to be slightly adjusted
  • Stroke width should be 1.5

On the left the design | On the right the current implementation
Frame 566

@francescospissu francescospissu mentioned this pull request Jul 8, 2022
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@91volt 91volt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 perfect

@francescospissu francescospissu force-pushed the fspissu/update-buttons-style branch from d4f024e to e8ebf2a Compare July 8, 2022 08:07
@francescospissu francescospissu merged commit d7a2d83 into main Jul 8, 2022
@francescospissu francescospissu deleted the fspissu/update-buttons-style branch July 8, 2022 08:43
@kittaakos
Copy link
Contributor

I like the new buttons. 😍 Is this the final design? Wouldn't it be a little bit better with spacing between the <input> and the buttons? What do you think? Thanks!

Screen Shot 2022-07-08 at 12 07 55

@francescospissu
Copy link
Contributor Author

I didn't notice, I'm fixing it. Thank you @kittaakos 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Progress on this prevented by an external cause topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update current button style to reflect design system
6 participants