-
-
Notifications
You must be signed in to change notification settings - Fork 431
Update buttons style #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buttons style #1122
Conversation
8e2b21e
to
7dfc762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
font-family: 'Open Sans'; | ||
font-style: normal; | ||
font-weight: 300; | ||
src: url(https://fonts.gstatic.com/s/opensans/v29/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0B4gaVI.woff2) format('woff2'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to have it at build time instead of fetching it. Or how does this work? 😊 Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it taking into account how something like this is already implemented here:
arduino-ide/arduino-ide-extension/src/browser/style/fonts.css
Lines 1 to 10 in 7f2b849
@font-face { | |
font-family: 'FontAwesome'; | |
src: | |
url('fonts/FontAwesome.ttf?nuchcq') format('truetype'), | |
url('fonts/FontAwesome.woff?nuchcq') format('woff'), | |
url('fonts/FontAwesome.svg?nuchcq#FontAwesome') format('svg'); | |
font-weight: normal; | |
font-style: normal; | |
font-display: block; | |
} |
I'll investigate how to add it at compile time. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francescospissu I think Akos comment was related to the fact that
src: url(https://fonts.gstatic.com/s/opensans/v29/memSYaGs126MiZpBA-UvWbX2vVnXBbObj2OVZyOOSr4dVJWUgsjZ0B4gaVI.woff2) format('woff2');
will not work without internet connection. (see the HTTP fetch)
while url('fonts/FontAwesome.woff?nuchcq') format('woff')
does, as the font is in the source files.
I agree we should avoid the fetch if possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the Open Sans font file in the fonts folder, here.
In this way we can avoid the fetch.
@francescospissu Great work, we are almost there in term of adherence to the design, some fixes:
On the left the design | On the right the current implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 perfect
…ound for active tree items
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
d4f024e
to
e8ebf2a
Compare
I didn't notice, I'm fixing it. Thank you @kittaakos 👍 |
Motivation
Buttons need to be updated to reflect the design system.
Change description
Changed the style of the buttons via CSS and and other minor changes.
Other information
Currently some colors do not reflect the design system because the related variables are not yet available. This PR cannot be merged until the variables are ready.
Reviewer checklist