Skip to content

Fix remote sketchbook widget rendering empty #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix remote sketchbook widget rendering empty #1101

merged 1 commit into from
Jul 4, 2022

Conversation

AlbyIanna
Copy link
Contributor

@AlbyIanna AlbyIanna commented Jun 23, 2022 •
edited
Loading

Motivation

Sometimes, the Remote Sketchbook content is empty. Clicking inside the widget content or resizing the sidebar will make the content appear.

Fixes #1129

Change description

Send a "fake" resize message to the cloud sketchbook tree to trigger a correct render.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested review from kittaakos and per1234 June 23, 2022 07:31
@AlbyIanna AlbyIanna marked this pull request as draft June 23, 2022 08:05
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 23, 2022
@AlbyIanna AlbyIanna changed the title Fix cloud sketchbook widget rendering empty Fix remote sketchbook widget rendering empty Jun 30, 2022
@AlbyIanna AlbyIanna marked this pull request as ready for review June 30, 2022 11:35
@AlbyIanna AlbyIanna force-pushed the remote-sketchbook-empty branch from 62a8fcd to 7684dbf Compare June 30, 2022 11:38
per1234
per1234 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am able to reproduce #1129 with the latest build from the main branch on both Windows and Linux.

This PR fixes #1129 for me.

kittaakos
kittaakos approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix; it looks good to me!

Please simplify the resize call with:

this.onResize(Widget.ResizeMessage.UnknownSize);

@AlbyIanna AlbyIanna force-pushed the remote-sketchbook-empty branch from 7684dbf to cd1bb09 Compare July 4, 2022 10:46
@AlbyIanna AlbyIanna merged commit d6899af into main Jul 4, 2022
@AlbyIanna AlbyIanna deleted the remote-sketchbook-empty branch July 4, 2022 13:52
@per1234 per1234 added the topic: cloud Related to Arduino Cloud and cloud sketches label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: cloud Related to Arduino Cloud and cloud sketches topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote sketchbook widget rendering empty
3 participants
@AlbyIanna @kittaakos @per1234