Skip to content

Sketchbook icons colors #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2022
Merged

Sketchbook icons colors #1095

merged 5 commits into from
Jun 29, 2022

Conversation

francescospissu
Copy link
Contributor

@francescospissu francescospissu commented Jun 22, 2022 •
edited
Loading

Motivation

Fixes the following issues:

Change description

  • Push, Pull and Menu button icons color changed
  • Local and remote sketchbook icons filled when selected

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

This was linked to issues Jun 22, 2022
Local and Cloud sketchbook icons should be filled when selected and outline when not selected. #1093
Closed
On light theme Push, Pull and menu buttons should be 424242 #1094
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 22, 2022
@francescospissu francescospissu force-pushed the fspissu/sketchbook-icons branch from bc5e5eb to 63467b3 Compare June 28, 2022 14:39
AlbyIanna
AlbyIanna approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francescospissu francescospissu merged commit 5499c25 into main Jun 29, 2022
@francescospissu francescospissu deleted the fspissu/sketchbook-icons branch June 29, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@fstasi fstasi Awaiting requested review from fstasi

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
3 participants
@francescospissu @AlbyIanna @per1234