Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR solves an issue that happens when uploading a sketch to some boards when the serial port is open.
Some boards need configuration parameters to append to the fqbn during the upload:
https://github.com/arduino/arduino-ide/blob/main/arduino-ide-extension/src/browser/contributions/upload-sketch.ts#L216-L219
and this is messing up with the
MonitorManager
because whennotifyUploadStarted()
is called, the monitor ID won't match theMonitorService
instance that handles the serial connection:https://github.com/arduino/arduino-ide/blob/main/arduino-ide-extension/src/node/monitor-manager.ts#L114-L119
Change description
Add some logic to make sure only the first part of an fqbn is relevant when creating a
monitorID
https://github.com/arduino/arduino-ide/compare/fix-monitor-id?expand=1#diff-cf90510ad3f811b7073a1934f11698463693bf446a2521eb2a55f27a48328427R218-R220
Other information
Reviewer checklist