Editor manager should be singleton, patched layout restorer to avoid duplicate editor tabs #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
topic: code
This was
linked to
issues
Jun 7, 2022
fstasi
approved these changes
Jun 7, 2022
Added some logging when filtering the layout data. Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
editor-manager-di
branch
2 times, most recently
from
d15e4b0 to
4d38eb4
Compare
kittaakos
changed the title
kittaakos
force-pushed
the
editor-manager-di
branch
from
4d38eb4 to
1fde017
Compare
added 2 commits
June 8, 2022 16:38
Customized the shell layout restorer: - If a resource is about to open in code editor and preview, do not open the preview. - If a resource is about to open in preview only, open a code editor instead. Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
editor-manager-di
branch
from
d6a6ccd to
16e4623
Compare
fstasi
approved these changes
Jun 8, 2022
| } | ||
| return desc; | ||
| }) | ||
| .filter(notEmpty); |
There was a problem hiding this comment.
for the sake of performance: I see 3 loops here: forEach, map, filter. If we expect this to be time consuming we could think of refactoring it a bit in the future. Btw this is fine as of now
3 tasks
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR should fix the duplicate editor tab issue.
Change description
Other information
Reviewer checklist