Skip to content

Add user-agent property to gRPC client #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmaglie opened this issue Jan 31, 2022 · 2 comments · Fixed by #834
Closed

Add user-agent property to gRPC client #790

cmaglie opened this issue Jan 31, 2022 · 2 comments · Fixed by #834
Assignees
Labels
conclusion: resolved Issue was resolved topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@cmaglie
Copy link
Member

cmaglie commented Jan 31, 2022

Is your feature request related to a problem? Please describe.
This feature request is related to this new feature of the arduno-cli: arduino/arduino-cli#1640
arduino-cli now passes a new ARDUINO_USER_AGENT env variable to all the tools used to compile and upload. In particular, while running as a daemon arduino-cli will pass also the name of the client using the daemon instance (in our case it will be ArduinoIDE), for example:

ARDUINO_USER_AGENT=arduino-cli/0.21.0 ArduinoIDE/2.0.0-rc3

Describe the solution you'd like
Since gRPC already supports passing the user-agent, I'd like this option to be set to ArduinoIDE/<version>, like ArudinoIDE/2.0.0-rc3

@cmaglie cmaglie added the type: enhancement Proposed improvement label Jan 31, 2022
@per1234 per1234 added topic: CLI Related to Arduino CLI topic: code Related to content of the project itself labels Jan 31, 2022
@fstasi fstasi added this to the arduino-ide rc4 milestone Jan 31, 2022
@fstasi fstasi assigned silvanocerza and unassigned AlbyIanna Jan 31, 2022
@fstasi fstasi modified the milestones: arduino-ide rc4, arduino-ide rc5 Jan 31, 2022
@PaulStoffregen
Copy link

@silvanocerza - Any chance to have the IDE send this info soon, now that CLI 0.21 is integrated? I need this info to begin testing on Teensy's upload tool to adapt between GUI vs CLI usage.

@silvanocerza
Copy link
Contributor

@PaulStoffregen I've opened a PR, you should be able to test it as soon as the workflows generate the build artifacts if you don't want to wait for it to be merged in main.

It's a small change so I would expect it will be merged in a short time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants