Skip to content

Maintain border on Serial Monitor input field when it loses focus #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
per1234 opened this issue Dec 13, 2021 · 0 comments
Open
3 tasks done

Maintain border on Serial Monitor input field when it loses focus #682

per1234 opened this issue Dec 13, 2021 · 0 comments
Assignees
@fstasi
Labels
criticality: medium Of moderate impact phase: implementation Work is in the implementation phase priority: high Resolution is a high priority topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 13, 2021 •
edited
Loading

Describe the problem

🐛 If you click on anything outside the Serial Monitor input field, the field loses its border and is not easily distinguishable from the output window.

To reproduce

  1. Select a board/port in the Arduino IDE.
  2. Open Serial Monitor.
  3. Add some text to the "Message" field.
  4. Click outside the message field.

🐛 Notice that there is now no indication that an input field exists:

Unknown-3.png

Expected behavior

A UI design that clearly identifies the Serial Monitor input field to the user under any conditions.

Arduino IDE version

Original report

2.0.0-rc2

Last verified with

d6a4b0f

Operating system

Windows

Operating system version

10

Additional context

The Arduino IDE 1.x Serial Monitor follows the standard GUI conventions, making use of the input field intuitive:

Unknown.png

Possibly related:

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added criticality: medium Of moderate impact phase: implementation Work is in the implementation phase topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor labels Dec 13, 2021
@rsora rsora added type: imperfection Perceived defect in any part of project priority: low Resolution is a low priority priority: high Resolution is a high priority and removed priority: low Resolution is a low priority labels Dec 21, 2021
kittaakos pushed a commit that referenced this issue Mar 29, 2023
fix: set monitor header background color
029ddbb 
Ref: #682
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Mar 30, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Mar 30, 2023
fix: propagate monitor errors to the frontend
a0a3bf4 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 30, 2023
fix: propagate monitor errors to the frontend
ba1d61f 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Mar 31, 2023
fix: propagate monitor errors to the frontend
9b8e941 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Apr 13, 2023
fix: propagate monitor errors to the frontend
c43d360 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Apr 13, 2023
@kittaakos
fix: propagate monitor errors to the frontend
80d5b5a 
 - Handle when the board's platform is not installed (Closes #1974)
 - UX: Smoother monitor widget reset (Closes #1985)
 - Fixed monitor <input> readOnly state (Closes #1984)
 - Set monitor widget header color (Ref #682)

Closes #1508

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fstasi fstasi

Labels
criticality: medium Of moderate impact phase: implementation Work is in the implementation phase priority: high Resolution is a high priority topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fstasi @per1234 @rsora