Skip to content

Remove **File > Close Editor** menu item #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
per1234 opened this issue Dec 3, 2021 · 0 comments · Fixed by #1351
Closed

Remove **File > Close Editor** menu item #660

per1234 opened this issue Dec 3, 2021 · 0 comments · Fixed by #1351
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 3, 2021

Describe the current behavior

A new menu item File > Close Editor was introduced recently. This closes the currently selected editor.

The code files in the root of an Arduino sketch are always opened in the Arduino IDE editors. It is very rare for users to have any other editors open in the IDE. File > Close Editor has no effect when a sketch tab is selected. Its purpose is not clear from the title since we have never used the term "editor" to refer to an individual tab (we call them "tabs"). When a non-sketch file is open in an editor, the X on the right side of its tab will be the obvious method for closing it (with an alternative of using the "View: Close Tab in Main Area" keyboard shortcut).

My opinion is that this File > Close Editor will only cause confusion and add unnecessary complexity to the Arduino IDE's primary UI. I suspect that its introduction was unplanned.

To reproduce

  1. Select File > Close Editor from the Arduino IDE menus

Note that it doesn't do anything.

Describe the request

Evaluate the need for File > Close Editor. If it doesn't offer anything of value to the users, remove it.

Desktop

  • OS: Windows 10
  • Version: 2.0.0-rc1-snapshot.f0d9894
    Date: 2021-11-30T16:25:41.414Z
    CLI Version: 0.20.1 [abb21449]
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Dec 3, 2021
@kittaakos kittaakos self-assigned this Aug 25, 2022
kittaakos pushed a commit that referenced this issue Aug 25, 2022
Closes #660

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Aug 25, 2022
Closes #660

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Aug 26, 2022
Closes #660

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants