Skip to content

Incorrect mouseover graphic for dirty indicator #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
per1234 opened this issue Dec 1, 2021 · 1 comment
Closed

Incorrect mouseover graphic for dirty indicator #647

per1234 opened this issue Dec 1, 2021 · 1 comment
Assignees
@fstasi
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Dec 1, 2021 •
edited
Loading

Describe the bug

The IDE shows a ⬤ on the right side of a tab when it is in an unsaved (AKA "dirty") state.

🐛 When the mouse pointer is moved over this indicator, it turns into an X with polka-dot background. The X is misleading because sketch code tabs are not closeable.

To Reproduce

  1. Select File > Preferences from the Arduino IDE menus.
  2. Uncheck the box next to "☐ Auto save".
  3. Click the OK button.
  4. Make a change to the sketch.
    🙂 You should now see a ⬤ on the right side of the tab that has unsaved content.
  5. Move the mouse pointer over the ⬤ on the tab.

🐛 There is an X with polka-dot background where the ⬤ is when not moused over:

image

Expected behavior

No change to the ⬤ dirty indicator when mousing over non-closeable tabs.

Desktop

  • OS: Windows 10
  • Version: 2.0.0-rc1-snapshot.f0d9894
    Date: 2021-11-30T16:25:41.414Z
    CLI Version: 0.20.1 [abb21449]
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 1, 2021
@per1234
Copy link
Contributor Author

per1234 commented Jun 10, 2022

Closing as duplicate of #1034, which is perhaps slightly superior due to having a video.

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2022
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fstasi fstasi

Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fstasi @per1234