Skip to content

[UI] The dirty/close decorator is broken in IDE #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kittaakos opened this issue Jun 10, 2022 · 0 comments · Fixed by #1351
Closed
3 tasks done

[UI] The dirty/close decorator is broken in IDE #1034

kittaakos opened this issue Jun 10, 2022 · 0 comments · Fixed by #1351
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jun 10, 2022 •
edited
Loading

Describe the problem

The dirty/close decorator does not look good when I hover over

To reproduce

  • Create a new sketch,
  • Disable auto-save,
  • Click on the Debug icon on the left,
  • Click on Start Debugging (the play button),
  • Editor opens and it's dirty, and
  • Hover over the close icon.
closeable_widget.mp4

Expected behavior

The X is visible when hovering over the dirty decorator.

Arduino IDE version

Version: 2.0.0-rc7 Date: 2022-06-09T08:19:19.877Z CLI Version: 0.23.0 [899dc91b] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added the type: imperfection Perceived defect in any part of project label Jun 10, 2022
@per1234 per1234 mentioned this issue Jun 10, 2022
Closed
@per1234 per1234 added the topic: code Related to content of the project itself label Jun 10, 2022
kittaakos pushed a commit that referenced this issue Aug 26, 2022
Fixed dirty indicator of uncloseable widgets.
9a2d13f 
Closes #1034.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos assigned kittaakos and unassigned AlbyIanna Aug 26, 2022
@kittaakos kittaakos mentioned this issue Aug 26, 2022
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Aug 26, 2022
Fixed dirty indicator of uncloseable widgets.
bd49329 
Closes #1034.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Aug 26, 2022
@kittaakos
Fixed dirty indicator of uncloseable widgets.
3afc2d7 
Closes #1034.

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 26, 2022
@per1234 per1234 changed the title [UI] The dirty/close decorator is broken in IDE2 [UI] The dirty/close decorator is broken in IDE Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1016, #1274 Aligned the "Save your sketch" dialog behavior arduino/arduino-ide
3 participants
@kittaakos @AlbyIanna @per1234