Skip to content

The changelog generation fails due to incompatible Node.js version #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
kittaakos opened this issue Aug 29, 2023 · 1 comment · Fixed by #2204
Closed
3 tasks done

The changelog generation fails due to incompatible Node.js version #2200

kittaakos opened this issue Aug 29, 2023 · 1 comment · Fixed by #2204
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Aug 29, 2023

Describe the problem

IDE2 blindly installs the latest dependency of @octokit/rest for the generation:

It fails:

Run yarn add @octokit/rest --ignore-workspace-root-check
yarn add v1.22.[19](https://github.com/arduino/arduino-ide/actions/runs/6010832696/job/16303060348#step:6:20)
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
warning @puppeteer/[email protected]: Invalid bin entry for "@puppeteer/browsers" (in "@puppeteer/browsers").
warning [email protected]: The engine "vscode" appears to be invalid.
error @octokit/[email protected]: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.[20](https://github.com/arduino/arduino-ide/actions/runs/6010832696/job/16303060348#step:6:21).2"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
Error: Process completed with exit code 1.

The latest version has dropped Node16 support: https://github.com/octokit/rest.js/releases/tag/v20.0.0

To reproduce

Run a changelog generation with Node.js 16

Expected behavior

either put the dependency into the main package.json to make sure it works with every yarn execution or pin the version (19.0.13) of the npm package that works with the current Node.js version.

Arduino IDE version

2.2.0

Operating system

N/A

Operating system version

CI

Additional context

Related #2199

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Aug 29, 2023
kittaakos pushed a commit that referenced this issue Aug 31, 2023
Pinned `@octokit/rest` to `19.0.13`, so that it works with Node.js 16+.

Closes #2200

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos
Copy link
Contributor Author

We need to clean this up. The @octokit/rest dependency is already in IDE2 with a different version, but it's unused, as the changelog script does not run yarn.

"@octokit/rest": "^18.12.0",

A related scripts cleanup issue: #1349

kittaakos pushed a commit that referenced this issue Aug 31, 2023
Pinned `@octokit/rest` to `19.0.13`, so that it works with Node.js 16+.

Closes #2200

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Aug 31, 2023
Pinned `@octokit/rest` to `19.0.13`, so that it works with Node.js 16+.

Closes #2200

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant