Skip to content

Example files - ask to save even if no changes were made to them. #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
KurtE opened this issue Jun 8, 2022 · 1 comment · Fixed by #1351
Closed
3 tasks done

Example files - ask to save even if no changes were made to them. #1026

KurtE opened this issue Jun 8, 2022 · 1 comment · Fixed by #1351
Assignees
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@KurtE
Copy link

KurtE commented Jun 8, 2022

Describe the problem

If I open up an example sketch like blink and simply use it to program the board, and then try to close it without making
any changes, unlike Arduino 1.x it asks me if I wish to save the sketch or not.

This is related to #893,
which I am glad was fixed, but I do think it should only ask if the user made changes to the sketch.

There are other related example sketch issues, but I am pretty sure they have been reported in the past including:

  1. Show sketch folder shows the folder within the temp directory, which feels wrong.

  2. Still looks like the examples don't show up in recent sketch list

  3. If the temporary folder is erased, like you have the blink window open, go away for awhile and Norton Desktop cleans up the temp directory and erases your sketch, you end up with a strange looking windows:
    image
    Note: I also saw some message in the window saying something like it can no longer track file changes... As there are too many... or some such thing (sorry should have taken picture then)

To reproduce

Go to examples: file->Examples->01 Basic -> Blink

then after the window opens, click on the close button and you will see the dialog asking if you wish to save.

The strange window issue, happens of Norton does a cleanup... Or you can emulate by opening the folder and delete all of the files out of that folder.

Expected behavior

Expect to only be asked to save a file if the file has been changed.

Arduino IDE version

Nightly build 20220608

Operating system

Windows

Operating system version

Windows 10

Additional context

Sorry if I missed a duplicate.

Also 2nd part not sure what to report... I know with Arduino 1.x when the temp is cleared, a compile will fail but the window still shows the file contents from before.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@KurtE KurtE added the type: imperfection Perceived defect in any part of project label Jun 8, 2022
@per1234 per1234 added the topic: code Related to content of the project itself label Jun 9, 2022
@per1234
Copy link
Contributor

per1234 commented Aug 2, 2022

Thanks so much for this report @KurtE. I have also found these unnecessary confirmation dialogs inconvenient.

I see we now have another report about this at #1274.

It is best to have only a single issue per subject so we can consolidate all relevant discussion to one place. Even though this one came first, the other has a little bit more information (the comment by kittaakos here), so I'll go ahead and close this in favor of the other.

I made sure to add a note there about how the issue applies to examples in addition to new sketches (the Arduino IDE opens examples as a new sketch, as you reported at #925), with a link to this issue to make sure it will be seen by the interested parties.

If you end up with additional information to share, feel free to comment in the other thread.

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2022
@per1234 per1234 assigned per1234 and unassigned AlbyIanna Aug 2, 2022
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Aug 2, 2022
@per1234 per1234 linked a pull request Aug 26, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants