Skip to content

Sketchbook view can't handle more than two tree levels #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
per1234 opened this issue Jun 1, 2022 · 1 comment · Fixed by #1144
Closed
3 tasks done

Sketchbook view can't handle more than two tree levels #1015

per1234 opened this issue Jun 1, 2022 · 1 comment · Fixed by #1144
Assignees
Labels
conclusion: resolved Issue was resolved priority: low Resolution is a low priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Jun 1, 2022

Describe the problem

The Arduino IDE's "Sketchbook" view allows the user to browse and open sketches in their sketchbook folder.

Users may find it useful to organize their sketches into subfolders of the sketchbook folder.

🐛 Sketches with a tree deeper than two levels are not displayed correctly and cannot be opened via the "Sketchbook" view.

To reproduce

  1. Select File > Save As... from the Arduino IDE menus.
  2. Save the sketch under a subfolder of your sketchbook folder:
    Arduino/
    └── SomeSubfolder/
        └── SomeSketch/
            └── SomeSketch.ino
    
  3. Select File > New from the Arduino IDE menus.
  4. Close the IDE window for the "SomeSketch" sketch.
    This is done for the demonstration that the sketch can't be opened via the "Sketchbook" view.
  5. Select File > Preferences... from the Arduino IDE menus.
  6. Check the box next to "☐ Show files inside Sketches.
    The issue also occurs with this setting disabled, except one additional tree level is possible due to the sketch file not counting toward the limit.
  7. Click the OK button.
  8. Open the "Sketchbook" view.
  9. Use the control to expand the "SomeSubfolder" folder.
    🐛 The expansion results in SomeSubfolder/SomeSketch:
    image
    rather than the expected tree:
    image
  10. Double click on "SomeSketch"
    🐛 The sketch does not open.

Expected behavior

"Sketchbook" view supports any reasonable level of folder depth.

Arduino IDE version

2.0.0-rc6-snapshot-5fc30bd

Operating system

Windows, Ubuntu

Operating system version

Windows 10, Ubuntu 20.04

Additional context

I bisected the introduction of this issue to 1ae60ec (it does not occur when using the build for b8c718c).


The issue also affects the "Remote Sketchbook" view in the same way.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 1, 2022
@per1234
Copy link
Contributor Author

per1234 commented Jun 12, 2022

I found the solution to this. The explorer.compactFolders settings key must be set to false.

I believe the issue was introduced by eclipse-theia/theia#10713 (note that the setting defaults to true)

@fstasi fstasi added the priority: low Resolution is a low priority label Jun 22, 2022
kittaakos pushed a commit that referenced this issue Jul 4, 2022
Use a default `false` value for the `explorer.compactFolders` preference

Closes #1015.

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Jul 5, 2022
Use a default `false` value for the `explorer.compactFolders` preference

Closes #1015.

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved priority: low Resolution is a low priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants