Skip to content

Commit 029ddbb

Browse files
author
Akos Kitta
committed
fix: set monitor header background color
Ref: #682 Signed-off-by: Akos Kitta <[email protected]>
1 parent 02da1c6 commit 029ddbb

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Diff for: arduino-ide-extension/src/browser/serial/monitor/monitor-widget.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ export class MonitorWidget extends ReactWidget {
185185
: undefined;
186186

187187
const baudrateOptions = baudrate?.values.map((b) => ({
188-
label: b + ' baud',
188+
label: nls.localize('arduino/monitor/baudRate', '{0} baud', b),
189189
value: b,
190190
}));
191191
const baudrateSelectedOption = baudrateOptions?.find(
@@ -195,7 +195,7 @@ export class MonitorWidget extends ReactWidget {
195195
const lineEnding =
196196
this.lineEndings.find(
197197
(item) => item.value === this.monitorModel.lineEnding
198-
) || this.lineEndings[1]; // Defaults to `\n`.
198+
) || MonitorEOL.DEFAULT;
199199

200200
return (
201201
<div className="serial-monitor">
@@ -242,8 +242,8 @@ export class MonitorWidget extends ReactWidget {
242242
);
243243
}
244244

245-
protected readonly onSend = (value: string) => this.doSend(value);
246-
protected async doSend(value: string): Promise<void> {
245+
protected readonly onSend = (value: string): void => this.doSend(value);
246+
protected doSend(value: string): void {
247247
this.monitorManagerProxy.send(value);
248248
}
249249

Diff for: arduino-ide-extension/src/browser/style/monitor.css

+3-2
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,19 @@
2020

2121
.serial-monitor .head {
2222
display: flex;
23-
padding: 5px;
23+
padding: 0px 5px 5px 0px;
2424
height: 27px;
25+
background-color: var(--theia-activityBar-background);
2526
}
2627

2728
.serial-monitor .head .send {
2829
display: flex;
2930
flex: 1;
30-
margin-right: 2px;
3131
}
3232

3333
.serial-monitor .head .send > input {
3434
line-height: var(--theia-content-line-height);
35+
height: 27px;
3536
width: 100%;
3637
}
3738

Diff for: i18n/en.json

+1
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@
329329
},
330330
"monitor": {
331331
"alreadyConnectedError": "Could not connect to {0} {1} port. Already connected.",
332+
"baudRate": "{0} baud",
332333
"connectionFailedError": "Could not connect to {0} {1} port.",
333334
"connectionFailedErrorWithDetails": "{0} Could not connect to {1} {2} port.",
334335
"connectionTimeout": "Timeout. The IDE has not received the 'success' message from the monitor after successfully connecting to it",

0 commit comments

Comments
 (0)