Skip to content

harden cert flash on windows pt3 (was using port before touch) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 15, 2021

I forgot to apply the fix from #76 to the certificate flashing 🤦

@umbynos umbynos requested a review from a team July 15, 2021 15:42
@umbynos umbynos self-assigned this Jul 15, 2021
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the issue before this change:

INFO[0005] Putting board into bootloader mode
INFO[0007] Found port to upload Loader: COM18
No device found on COM14
Error during certificates flashing: exit status 1

after this change, the arduino-fwuploader certificates flash command is able to proceed successfully.

Thanks Umberto!

@umbynos umbynos merged commit c8d7a89 into main Jul 16, 2021
@umbynos umbynos deleted the umbynos/fix_cert_win branch July 16, 2021 07:51
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants