Skip to content

Remove support for SARA module #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Remove support for SARA module #65

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a0875de
remove old sara fw and loader sketch
umbynos Jun 23, 2021
9307442
remove sara related code in `arduino-fwuploader` binary
umbynos Jun 23, 2021
1e40ec4
remove sara from the generator
umbynos Jun 23, 2021
df99d64
remove sara also in test indexes and regenerate signatures
umbynos Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Firmware/Certificates updater for WINC and NINA Wifi module

Use this tool to update the firmware and/or add SSL certificates for any WINC, NINA or SARA module.
Use this tool to update the firmware and/or add SSL certificates for any WINC, NINA module.

## Install

Expand Down
2 changes: 0 additions & 2 deletions cli/certificates/flash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ func run(cmd *cobra.Command, args []string) {
switch moduleName {
case "NINA":
f, err = flasher.NewNinaFlasher(uploadPort)
case "SARA":
f, err = flasher.NewSaraFlasher(uploadPort)
case "WINC1500":
f, err = flasher.NewWincFlasher(uploadPort)
default:
Expand Down
2 changes: 0 additions & 2 deletions cli/firmware/flash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,6 @@ func updateFirmware(board *firmwareindex.IndexBoard, commandLine []string, modul
switch moduleName {
case "NINA":
f, err = flasher.NewNinaFlasher(uploadPort)
case "SARA":
f, err = flasher.NewSaraFlasher(uploadPort)
case "WINC1500":
f, err = flasher.NewWincFlasher(uploadPort)
default:
Expand Down
Binary file removed firmwares/SARA/5.6A2_01/5.6A2.00-to-5.6A2.01.pkg
View file
Open in desktop
Binary file not shown.
Binary file removed firmwares/SARA/5.6A2_01/5.6A2_01_to_99.pkg
View file
Open in desktop
Binary file not shown.
Binary file removed firmwares/SARA/5.6A2_01/99_to_5.6A2_01.pkg
View file
Open in desktop
Binary file not shown.
Binary file removed firmwares/SARA/SerialSARAPassthrough.ino.bin
View file
Open in desktop
Binary file not shown.
230 changes: 0 additions & 230 deletions flasher/sara.go
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions generator/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"nano_33_iot": "arduino:samd:nano_33_iot",
"mkrvidor4000": "arduino:samd:mkrvidor4000",
"uno2018": "arduino:megaavr:uno2018",
"mkrnb1500": "arduino:samd:mkrnb1500",
"nanorp2040connect": "arduino:mbed_nano:nanorp2040connect",
}

Expand Down Expand Up @@ -212,7 +211,6 @@ def generate_boards_json(input_data, arduino_cli_path):
"firmware": [],
},
"arduino:megaavr:uno2018": {"fqbn": "arduino:megaavr:uno2018", "firmware": []},
"arduino:samd:mkrnb1500": {"fqbn": "arduino:samd:mkrnb1500", "firmware": []},
"arduino:mbed_nano:nanorp2040connect": {
"fqbn": "arduino:mbed_nano:nanorp2040connect",
"firmware": [],
Expand Down
34 changes: 0 additions & 34 deletions generator/raw_boards.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,40 +473,6 @@
}
]
},
"mkrnb1500": {
"firmwares/SARA": [
{
"version": "SARA",
"Path": "firmwares/SARA/SerialSARAPassthrough.ino.bin",
"Name": "firmwares SARA",
"IsLoader": true
}
],
"firmwares/SARA/5.6A2.00-to-5.6A2.01": [
{
"version": "SARA/5.6A2.00-to-5.6A2.01",
"Path": "firmwares/SARA/5.6A2_01/5.6A2.00-to-5.6A2.01.pkg",
"Name": "SARA 5.6A2_01 (5.6A2.00-to-5.6A2.01.pkg)",
"IsLoader": false
}
],
"firmwares/SARA/5.6A2_01_to_99": [
{
"version": "SARA/5.6A2_01_to_99",
"Path": "firmwares/SARA/5.6A2_01/5.6A2_01_to_99.pkg",
"Name": "SARA 5.6A2_01 (5.6A2_01_to_99.pkg)",
"IsLoader": false
}
],
"firmwares/SARA/99_to_5.6A2_01": [
{
"version": "SARA/99_to_5.6A2_01",
"Path": "firmwares/SARA/5.6A2_01/99_to_5.6A2_01.pkg",
"Name": "SARA 5.6A2_01 (99_to_5.6A2_01.pkg)",
"IsLoader": false
}
]
},
"nanorp2040connect": {
"firmwares/NINA": [
{
Expand Down
4 changes: 0 additions & 4 deletions indexes/firmwareindex/firmwareindex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@ func LoadIndexNoSign(jsonIndexFile *paths.Path) (*Index, error) {

// Determine latest firmware for each board
for _, board := range index.Boards {
if board.Module == "SARA" {
// TODO implement?? by default you have to specify the version
continue
}
for _, firmware := range board.Firmwares {
if board.LatestFirmware == nil || firmware.Version.GreaterThan(board.LatestFirmware.Version) {
board.LatestFirmware = firmware
Expand Down