Skip to content

rename FirmwareUploader to arduino-fwuploader #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2021
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jun 18, 2021

For consistency with other arduino tools we decided to rename the FirmwareUploader to arduino-fwuploader
The changes are similar to #21

@umbynos umbynos requested a review from a team June 18, 2021 15:42
@umbynos umbynos self-assigned this Jun 18, 2021
@umbynos umbynos added topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure labels Jun 18, 2021
@umbynos umbynos changed the title rename FirmwareUploader to **arduino-firmwareuploader** rename FirmwareUploader to arduino-firmwareuploader Jun 18, 2021
@umbynos umbynos marked this pull request as draft June 18, 2021 16:00
@umbynos
Copy link
Contributor Author

umbynos commented Jun 21, 2021

The CI is failing on windows because of go build -o {{.PROJECT_NAME}}. The-o flag forces the binary name, but on win it does not take care of adding automagically the .exe extension required on the OS. So I'm reverting that change. The default name for the go build command apparently is the name of the parent folder (and in this case the repo name). The repository name will be changed shortly

@umbynos umbynos marked this pull request as ready for review June 21, 2021 12:41
@umbynos umbynos requested a review from silvanocerza June 21, 2021 13:02
@umbynos
Copy link
Contributor Author

umbynos commented Jun 21, 2021

I would like to follow this strategy:

  1. approval
  2. rename the repo to arduino-fwuploader
  3. merge

@umbynos
Copy link
Contributor Author

umbynos commented Jun 21, 2021

PS I did not rename the loader sketches inside firmwares/<module_name>/FirmwareUploader.<board>.ino.[bin/elf] because of:

  1. this
  2. They are the compiled version of this. And in my opinion is better to keep things consistent

@umbynos umbynos merged commit d3bcb8c into main Jun 21, 2021
@umbynos umbynos deleted the umbynos/rename branch June 21, 2021 13:16
@umbynos umbynos changed the title rename FirmwareUploader to arduino-firmwareuploader rename FirmwareUploader to arduino-fwuploader Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants