Skip to content

Bump pyyaml dependency to fix failing dependencies install #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Jan 8, 2025

Bumped the pyyaml dependency and generated the lock file with poetry update pyyaml. This shoud fix issues related to dependencies installation like the following one:

at /Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/poetry/installation/chef.py:164 in _prepare
      160│ 
      161│                 error = ChefBuildError("\n\n".join(message_parts))
      162│ 
      163│             if error is not None:
    → 164│                 raise error from None
      165│ 
      166│             return path
      167│ 
      168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but with pyyaml (5.4.1) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "pyyaml (==5.4.1)"'.

@MatteoPologruto MatteoPologruto added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Jan 8, 2025
@MatteoPologruto MatteoPologruto self-assigned this Jan 8, 2025
@MatteoPologruto
Copy link
Contributor Author

The failing workflow runs are unrelated to the changes. See editorconfig-checker/editorconfig-checker#409

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package should not be added as a dependency, since it is only a transitive dependency.

Instead, it should only be updated, which can be done by running the following command:

poetry update pyyaml

and then checking in the resulting change to poetry.lock.

@MatteoPologruto MatteoPologruto changed the title Add pyyaml as a dependency to fix failing dependencies install Bump pyyaml dependency to fix failing dependencies install Jan 8, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matteo!

@MatteoPologruto MatteoPologruto merged commit 5942b5a into main Jan 8, 2025
23 checks passed
@MatteoPologruto MatteoPologruto deleted the bump-py-deps branch January 8, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants