Bunch of refactorings / Added support for Arduino Nano RP2040 Connect #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed DumpAndFlash (it doesn't work reliably) - simplified ctx message passing
umbynos
added a commit
that referenced
this pull request
Apr 23, 2021
…#20) * Close flasher after completing operations * Refactored and simplified Programmer - removed DumpAndFlash (it doesn't work reliably) - simplified ctx message passing * Removed now unused DumpAndFlash methods * Added Arduino Nano RP2040 Connect support * Fix upload problems * Fixed bossac init... ooops * fix import removed by error * bump arduino-cli -> include the latest updates in serialutils.go Co-authored-by: Umberto Baldi <[email protected]> Co-authored-by: Umberto Baldi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flasher.Closehandling more consistentDumpAndFlashfunction (it was not really working)ProgrammerinterfaceI'm waiting for the final release of the firmware so I'm pushing as a draft in the meantime.