Remove certificates, they are obsolete and are out of sync #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Cert has been removed from the NINA firmware long time ago arduino/nina-fw@53580a0#diff-88545c89de17b94ff13f555cea95c4971daff07b1e887f1acb0811e7a674347cL545-L572. Furthermore, is about to expire.
|
Actually, all the certs present in the |
|
The chek-certificates workflow needs to be adjusted because it does not expect a single bundle of certificates. |
umbynos
force-pushed
the
umbynos/remove_geotrust_cert
branch
from
0a74467 to
b9acf06
Compare
…re no more certs in this repo
umbynos
force-pushed
the
umbynos/remove_geotrust_cert
branch
from
b9acf06 to
e629475
Compare
umbynos
changed the title
|
After a discussion with @per1234 we decided it was better to remove completely the certs and update the documentation instead. The check certificates workflow is not useful anymore now. |
cmaglie
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Cert has been removed from the NINA firmware long time ago arduino/nina-fw@53580a0#diff-88545c89de17b94ff13f555cea95c4971daff07b1e887f1acb0811e7a674347cL545-L572. Furthermore, is about to expire.
The certificates under
cert/folder are there only there because if the user decides to upload a new self-signed cert, the partition inside the NINA module containing the certs gets wiped out, so it's required to upload the cert with a command line containing all the cert the user wants on the board. https://arduino.github.io/arduino-fwuploader/dev/usage/#certificates