Enable pulseIn() sketches for Portenta in sketch compilation workflow
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time the "Compile Examples" CI workflow was written, the Portenta H7 board did not have a `pulseIn()` function. Although this was a legitimate bug, since this was an issue with the `arduino/ArduinoCore-mbed` code base, already tracked there, and unrelated to the code hosted in this repository, it was determined that the best approach would be to configure the workflow to not compile the examples that used `pulseIn()` for the Portenta H7. Since that time, `pulseIn()` has been implemented for Portenta H7 and so we can now compile these sketches for that board.
This attribute was used to configure the workflow to skip compilation of examples that used `pulseIn()` for boards that were already known to not provide this functionality. The only such board was the Portenta H7 and that has since gained a `pulseIn()`. Since all boards now have `pulseIn()`, the attribute no longer serves a purpose and can be removed from the workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time the "Compile Examples" CI workflow was written, the Portenta H7 board did not have a
pulseIn()function.Although this was a legitimate bug, since this was an issue with the
arduino/ArduinoCore-mbedcode base, alreadytracked there (arduino/ArduinoCore-mbed#48), and unrelated to the code hosted in this repository, it was determined that the best approach would be to configure the workflow to not compile the examples that used
pulseIn()for the Portenta H7.Since that time,
pulseIn()has been implemented for Portenta H7 (arduino/ArduinoCore-mbed@f5ddfa8) and so we can now compile these sketches for that board.