Skip to content

Commit 3cf1130

Browse files
committed
Remove "pulsein" board attribute from "Compile Examples" CI workflow
This attribute was used to configure the workflow to skip compilation of examples that used `pulseIn()` for boards that were already known to not provide this functionality. The only such board was the Portenta H7 and that has since gained a `pulseIn()`. Since all boards now have `pulseIn()`, the attribute no longer serves a purpose and can be removed from the workflow.
1 parent 9b2ba95 commit 3cf1130

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

Diff for: .github/workflows/compile-examples.yml

+1-19
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ jobs:
7878
- examples/04.Communication/SerialEvent
7979
- examples/04.Communication/VirtualColorMixer
8080
- examples/05.Control
81-
- examples/06.Sensors/ADXL3xx
82-
- examples/06.Sensors/Knock
81+
- examples/06.Sensors
8382
- examples/07.Display
8483
- examples/08.Strings
8584
- examples/11.ArduinoISP
@@ -95,52 +94,44 @@ jobs:
9594
serial1: false
9695
starter-kit: true
9796
tone: true
98-
pulsein: true
9997
# Adding this in addition to the Uno because it has 1.5 kB less available flash
10098
- fqbn: arduino:avr:nano
10199
usb: false
102100
serial1: false
103101
starter-kit: false
104102
tone: true
105-
pulsein: true
106103
- fqbn: arduino:avr:leonardo
107104
usb: true
108105
serial1: true
109106
starter-kit: false
110107
tone: true
111-
pulsein: true
112108
- fqbn: arduino:megaavr:uno2018:mode=off
113109
usb: false
114110
serial1: true
115111
starter-kit: false
116112
tone: true
117-
pulsein: true
118113
- fqbn: arduino:samd:mkrzero
119114
usb: true
120115
serial1: true
121116
starter-kit: false
122117
tone: true
123-
pulsein: true
124118
- fqbn: arduino:mbed_nano:nano33ble
125119
usb: false
126120
serial1: true
127121
starter-kit: false
128122
tone: true
129-
pulsein: true
130123
- fqbn: arduino:mbed_portenta:envie_m7
131124
usb: false
132125
serial1: true
133126
starter-kit: false
134127
tone: true
135-
pulsein: true
136128
- fqbn: arduino:sam:arduino_due_x
137129
usb: true
138130
serial1: true
139131
starter-kit: false
140132
# Bug report: https://github.com/arduino/ArduinoCore-sam/issues/24
141133
# Change the value to true once it is fixed.
142134
tone: false
143-
pulsein: true
144135

145136
# Make board type-specific customizations to the matrix jobs
146137
include:
@@ -184,14 +175,6 @@ jobs:
184175
- board:
185176
tone: false
186177
tone-sketch-paths: ""
187-
- board:
188-
pulsein: true
189-
pulsein-sketch-paths: |
190-
- examples/06.Sensors/Memsic2125
191-
- examples/06.Sensors/Ping
192-
- board:
193-
pulsein: false
194-
pulsein-sketch-paths: ""
195178

196179
steps:
197180
- name: Checkout
@@ -210,4 +193,3 @@ jobs:
210193
${{ matrix.serial1-sketch-paths }}
211194
${{ matrix.starter-kit-sketch-paths }}
212195
${{ matrix.tone-sketch-paths }}
213-
${{ matrix.pulsein-sketch-paths }}

0 commit comments

Comments
 (0)