Skip to content

Commit 9b2ba95

Browse files
committedAug 2, 2021
Enable pulseIn() sketches for Portenta in sketch compilation workflow
At the time the "Compile Examples" CI workflow was written, the Portenta H7 board did not have a `pulseIn()` function. Although this was a legitimate bug, since this was an issue with the `arduino/ArduinoCore-mbed` code base, already tracked there, and unrelated to the code hosted in this repository, it was determined that the best approach would be to configure the workflow to not compile the examples that used `pulseIn()` for the Portenta H7. Since that time, `pulseIn()` has been implemented for Portenta H7 and so we can now compile these sketches for that board.
1 parent 759c03b commit 9b2ba95

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed
 

‎.github/workflows/compile-examples.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,7 @@ jobs:
132132
serial1: true
133133
starter-kit: false
134134
tone: true
135-
# Bug report: https://github.com/arduino/ArduinoCore-mbed/issues/48
136-
# Change the value to true once it is fixed.
137-
pulsein: false
135+
pulsein: true
138136
- fqbn: arduino:sam:arduino_due_x
139137
usb: true
140138
serial1: true

0 commit comments

Comments
 (0)
Please sign in to comment.