Skip to content

Autostart is handled by the agent itself #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 5, 2023
Merged

Autostart is handled by the agent itself #781

merged 10 commits into from
May 5, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Apr 28, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Change

  • What is the current behavior?

Fix #738:
The agent is able to put itself in autostart using installbuilder configuration

  • What is the new behavior?

We added a new config option in config.ini file, that allows the agent to put itsef in autostart (using launchd plist file and launchctl command). We removed this option from installbuilder generated installer.

  • Does this PR introduce a breaking change?

Probably yes

  • Other information:

@umbynos umbynos self-assigned this Apr 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.24 ⚠️

Comparison is base (e40ebde) 11.29% compared to head (7315425) 11.05%.

❗ Current head 7315425 differs from pull request most recent head 637ae21. Consider uploading reports for the commit 637ae21 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   11.29%   11.05%   -0.24%     
==========================================
  Files          54       55       +1     
  Lines        3948     4033      +85     
==========================================
  Hits          446      446              
- Misses       3447     3532      +85     
  Partials       55       55              
Flag Coverage Δ
unit 11.05% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/autostart.go 0.00% <0.00%> (ø)
config/config.go 0.00% <0.00%> (ø)
main.go 2.43% <0.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos changed the title Create autostart file on first run of the agent Autostart is handled by the agent itself Apr 28, 2023
@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself os: macos Specific to macOS operating system labels Apr 28, 2023
@umbynos umbynos marked this pull request as ready for review April 28, 2023 16:08
@umbynos
Copy link
Contributor Author

umbynos commented Apr 28, 2023

@umbynos umbynos requested a review from cmaglie May 2, 2023 13:53
@umbynos umbynos merged commit 7f31d0e into main May 5, 2023
@umbynos umbynos deleted the autostart branch May 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create autostart file on first run of the agent
3 participants