Embed more files content using `embed` #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmaglie merged 2 commits into main from more_embedding

Feb 9, 2023

Member

cmaglie commented Feb 9, 2023

Please check if the PR fulfills these requirements

The PR has no duplicates (please search among the Pull Requests
before creating one)
Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce?
Remove hardcoding of files in favor of embed-ing.

What is the current behavior?
No changes in behavior

What is the new behavior?

Does this PR introduce a breaking change?

Other information:

umbynos and others added 2 commits

February 9, 2023 18:17


          use go:embed for the HTML home

c82a634


          use go:embed for the icons

df5491c

cmaglie self-assigned this

cmaglie requested a review from umbynos

February 9, 2023 17:29

cmaglie added type: enhancement topic: code labels

umbynos approved these changes

View reviewed changes

cmaglie merged commit bd3ba84 into main

cmaglie deleted the more_embedding branch

February 9, 2023 17:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code type: enhancement