Skip to content

Rework config.ini path handling #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 9, 2023
Merged

Rework config.ini path handling #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
419741d
remove `embedded_autoextract`, it has never been used
umbynos Nov 8, 2022
46aebbf
rework `config.ini` searching
umbynos Nov 9, 2022
e8b148e
fine-tune a config searching and parsing
umbynos Nov 10, 2022
7ab1736
enable `ARDUINO_CREATE_AGENT_CONFIG` env var to specify the config.ini
umbynos Nov 10, 2022
8518826
crashreports are now created in `.arduino-create/logs` to preserve ma…
umbynos Nov 21, 2022
3f9a6c6
embed config file and change a bit the logic of searching
umbynos Dec 5, 2022
fd31f87
remove `config.ini` from the CI, now it's generated by the executable
umbynos Dec 6, 2022
640587a
Use more appropriate directory folders for config.ini
cmaglie Feb 9, 2023
67ce938
Moved config stuff in config.go
cmaglie Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/publish-go-tester-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,10 @@ jobs:
run: task go:build
if: runner.os == 'macOS'

# config.ini is required by the executable when it's run
- name: Upload artifacts
uses: actions/upload-artifact@v3
with:
name: arduino-create-agent-${{ matrix.os }}${{ matrix.arch }}
path: |
arduino-create-agent*
config.ini
if-no-files-found: error
6 changes: 0 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,12 @@ jobs:
aws s3 sync public/ s3://${{ secrets.DOWNLOADS_BUCKET }}${{ env.OLD_TARGET }}
if: steps.prerelease.outputs.IS_PRE != 'true'

# config.ini is required by the executable when it's run
- name: Upload artifacts
uses: actions/upload-artifact@v3
with:
name: ${{ env.PROJECT_NAME }}-${{ matrix.os }}${{ matrix.arch }}
path: |
${{ env.PROJECT_NAME }}*
config.ini
if-no-files-found: error

create-macos-bundle:
Expand All @@ -164,10 +162,6 @@ jobs:
- name: Remove placeholder file
run: rm -rf ${{ env.EXE_PATH }}.empty

- name: Move config.ini to the Resources dir
working-directory: ${{ env.EXE_PATH }}
run: mv config.ini ../Resources/

# zip artifacts do not mantain executable permission
- name: Make executable
run: chmod -v +x ${{ env.EXE_PATH }}${{ env.PROJECT_NAME }}
Expand Down
Loading