Skip to content

Fix amd64 darwin install wrong tool (amd64) #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Fix amd64 darwin install wrong tool (amd64) #753

merged 5 commits into from
Jan 9, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 23, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Fix #751

  • What is the current behavior?

See #751

  • What is the new behavior?

The agent should be able to select the correct tool system to download

  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself os: macos Specific to macOS operating system type: imperfection Perceived defect in any part of project labels Dec 23, 2022
@umbynos umbynos requested a review from cmaglie December 23, 2022 16:42
@umbynos umbynos self-assigned this Dec 23, 2022
@umbynos
Copy link
Contributor Author

umbynos commented Dec 23, 2022

See the failing tests:

=== RUN   TestDownloadCorrectPlatform/darwinamd64
    download_test.go:62: 
        	Error Trace:	/home/runner/work/arduino-create-agent/arduino-create-agent/tools/download_test.go:62
        	Error:      	Not equal: 
        	            	expected: "arm64-apple-darwin"
        	            	actual  : "x86_64-apple-darwin"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-arm64-apple-darwin
        	            	+x86_64-apple-darwin
        	Test:       	TestDownloadCorrectPlatform/darwinamd64

@codecov-commenter
Copy link

Codecov Report

Base: 11.05% // Head: 11.57% // Increases project coverage by +0.51% 🎉

Coverage data is based on head (20f8d55) compared to base (58d2960).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   11.05%   11.57%   +0.51%     
==========================================
  Files          50       50              
  Lines        3853     3853              
==========================================
+ Hits          426      446      +20     
+ Misses       3373     3352      -21     
- Partials       54       55       +1     
Flag Coverage Δ
unit 11.57% <33.33%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/download.go 30.62% <33.33%> (+4.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos merged commit a27cbf7 into main Jan 9, 2023
@umbynos umbynos deleted the fix-751 branch January 9, 2023 15:58
@umbynos
Copy link
Contributor Author

umbynos commented Jan 9, 2023

PS I reverted the bump for www.github.com/xrash/smetrics (done in #746), because the old version of the algorithm was giving different similarity and the problem was not happening...
Yeah this library needs replacing for sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Darwin/amd64 installs wrong tools (darwin/amd64)
3 participants