Skip to content

Add Lint and check formatting of a Go module workflow #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2022
Merged

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 1, 2022

On every push and pull request that affects relevant files, check the repository's Go module for:

  • Common detectable errors in the code.
  • Use of outdated APIs
  • Code style violations
  • Code formatting inconsistency
  • Misconfiguration

@umbynos umbynos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 1, 2022
@umbynos umbynos self-assigned this Dec 1, 2022
@umbynos umbynos changed the title Check go Add Lint and check formatting of a Go module workflow Dec 1, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 8.45% // Head: 11.08% // Increases project coverage by +2.63% 🎉

Coverage data is based on head (f667602) compared to base (31b0a9d).
Patch coverage: 1.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            main     #742      +/-   ##
=========================================
+ Coverage   8.45%   11.08%   +2.63%     
=========================================
  Files         64       50      -14     
  Lines       5052     3853    -1199     
=========================================
  Hits         427      427              
+ Misses      4571     3372    -1199     
  Partials      54       54              
Flag Coverage Δ
unit 11.08% <1.78%> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bufferflow_default.go 0.00% <ø> (ø)
bufferflow_timed.go 0.00% <ø> (ø)
bufferflow_timedraw.go 0.00% <ø> (ø)
certificates.go 0.00% <0.00%> (ø)
conn.go 0.00% <0.00%> (ø)
discovery.go 0.00% <0.00%> (ø)
hub.go 0.00% <0.00%> (ø)
icon/iconlinux.go 0.00% <ø> (ø)
info.go 0.00% <0.00%> (ø)
killbrowser/killbrowser_linux.go 0.00% <ø> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

On every push and pull request that affects relevant files, check the Go module for:

- Common detectable errors in the code.
- Use of outdated APIs
- Code style violations
- Code formatting inconsistency
- Misconfiguration
@umbynos umbynos merged commit 6257da8 into main Dec 2, 2022
@umbynos umbynos deleted the check-go branch December 2, 2022 09:21
umbynos added a commit that referenced this pull request Dec 2, 2022
umbynos added a commit that referenced this pull request Dec 2, 2022
* bump go version to the latest available one

* bump go mod to 1.19

* forgot to remove this in #742

* `go get` starting from 1.17 is deprecated to install binaries

https://go.dev/doc/go-get-install-deprecation

* Go dropped support for x87 in go 1.15 golang/go#40255

* fix buildtag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants