Skip to content

General enhancements to macOS ventura binary #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 28, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Enhancements

  • What is the current behavior?

    • MacOS Ventura does not like that the agent binary creates files in the same directory where the binary sits
    • The agent was not able to generate the config file on firts run
  • What is the new behavior?

  1. config.ini:
    • The config searching/creation has been enhanced, now the agent is able to generate the config on first start (for more details see config.ini file should be created in the user folder #733)
    • I've added the possibility to specify the config path with a special env var: ARDUINO_CREATE_AGENT_CONFIG
  2. additional-config.ini needed some change as well. Now it's handled correctly but in the user dir and not in the binary folder.
  3. logs/ directory containing crash reports has been moved to user dir.
  4. Along the way I removed some unused functionality, like the "embeddedAutoextract" feature, which has never been used and used the embed package to remove duplicated files
  • Does this PR introduce a breaking change?

yes, docs need to be updated accordingly after the merge

  • Other information:

Some of the commits are part of the 1.2.7-ventura release

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself os: macos Specific to macOS operating system labels Nov 28, 2022
@umbynos umbynos self-assigned this Nov 28, 2022
@umbynos umbynos marked this pull request as draft November 28, 2022 17:06
@umbynos umbynos force-pushed the fix-(s)ventura-code branch 2 times, most recently from ce7ed4e to 23e97e0 Compare November 29, 2022 13:52
@umbynos umbynos marked this pull request as ready for review November 29, 2022 14:27
@umbynos umbynos added this to the MacOS Ventura Support milestone Nov 29, 2022
@umbynos umbynos force-pushed the fix-(s)ventura-code branch from 23e97e0 to f10d5f8 Compare December 5, 2022 15:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 11.40% // Head: 11.23% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (60d58c1) compared to base (c724474).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   11.40%   11.23%   -0.18%     
==========================================
  Files          51       52       +1     
  Lines        3910     3971      +61     
==========================================
  Hits          446      446              
- Misses       3409     3470      +61     
  Partials       55       55              
Flag Coverage Δ
unit 11.23% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
certificates.go 0.00% <0.00%> (ø)
config.go 0.00% <0.00%> (ø)
hub.go 0.00% <0.00%> (ø)
icon/iconlinux.go 0.00% <0.00%> (ø)
main.go 2.50% <0.00%> (+0.16%) ⬆️
systray/systray.go 0.00% <0.00%> (ø)
systray/systray_real.go 0.00% <0.00%> (ø)
update.go 0.00% <0.00%> (ø)
updater/updater.go 0.00% <0.00%> (ø)
updater/updater_default.go 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos umbynos force-pushed the fix-(s)ventura-code branch 6 times, most recently from 2db4840 to 92bc9b6 Compare December 13, 2022 12:34
@umbynos umbynos linked an issue Dec 13, 2022 that may be closed by this pull request
@umbynos umbynos force-pushed the fix-(s)ventura-code branch 4 times, most recently from 2bec9d8 to 1165c4f Compare December 14, 2022 16:06
@umbynos umbynos linked an issue Dec 14, 2022 that may be closed by this pull request
@umbynos umbynos force-pushed the fix-(s)ventura-code branch from 61b004b to 8016a01 Compare December 15, 2022 16:21
@umbynos umbynos marked this pull request as draft December 15, 2022 16:22
@umbynos umbynos force-pushed the fix-(s)ventura-code branch 2 times, most recently from 17a8152 to 9c352b3 Compare December 20, 2022 16:21
@cmaglie cmaglie force-pushed the fix-(s)ventura-code branch from 9e4409b to 14fc5d2 Compare January 27, 2023 17:23
@cmaglie cmaglie force-pushed the fix-(s)ventura-code branch 2 times, most recently from 60d58c1 to 51cb101 Compare February 13, 2023 09:39
@umbynos umbynos changed the base branch from main to refactor_updater February 13, 2023 09:40
Base automatically changed from refactor_updater to main February 14, 2023 09:42
umbynos and others added 6 commits February 14, 2023 10:44
* remove some code duplication regarding prerelease calculation

* add upload of the notarized bundle to s3 download bucket

* add upload of the notarized bundle to s3 download bucket
* add json to enable autoupdate with the new agent logic

* binary output of the archive https://unix.stackexchange.com/questions/3675/how-can-i-get-a-base64-encoded-shax-on-the-cli

* workaround to allow darwin-arm64 to autoupdate

* parallelize bundle creation and notarization.
This will be helpful if/when we decide to build for darwin-arm64.
For now this is useful because we do not offer a binary for m1 yet,
`runtime.GOARCH` on an m1 machine returns ARM64, so the call for the update file would fail
This is required because the auto-update uses the function

warning: 'openApplicationAtURL:configuration:completionHandler:' is only available on macOS 10.15 or newer [-Wunguarded-availability-new]
@cmaglie cmaglie force-pushed the fix-(s)ventura-code branch from 51cb101 to d8e770c Compare February 14, 2023 09:44
@cmaglie
Copy link
Member

cmaglie commented Feb 14, 2023

Closing because the original PR has been split into smaller PRs -> https://github.com/arduino/arduino-create-agent/milestone/1?closed=1

@cmaglie cmaglie closed this Feb 14, 2023
@cmaglie cmaglie deleted the fix-(s)ventura-code branch February 14, 2023 09:49
@umbynos umbynos removed this from the MacOS Ventura Support milestone Feb 14, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted os: macos Specific to macOS operating system topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants