-
-
Notifications
You must be signed in to change notification settings - Fork 150
General enhancements to macOS ventura binary #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ce7ed4e
to
23e97e0
Compare
23e97e0
to
f10d5f8
Compare
Codecov ReportBase: 11.40% // Head: 11.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 11.40% 11.23% -0.18%
==========================================
Files 51 52 +1
Lines 3910 3971 +61
==========================================
Hits 446 446
- Misses 3409 3470 +61
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2db4840
to
92bc9b6
Compare
2bec9d8
to
1165c4f
Compare
61b004b
to
8016a01
Compare
17a8152
to
9c352b3
Compare
9e4409b
to
14fc5d2
Compare
60d58c1
to
51cb101
Compare
* remove some code duplication regarding prerelease calculation * add upload of the notarized bundle to s3 download bucket * add upload of the notarized bundle to s3 download bucket
* add json to enable autoupdate with the new agent logic * binary output of the archive https://unix.stackexchange.com/questions/3675/how-can-i-get-a-base64-encoded-shax-on-the-cli * workaround to allow darwin-arm64 to autoupdate * parallelize bundle creation and notarization. This will be helpful if/when we decide to build for darwin-arm64. For now this is useful because we do not offer a binary for m1 yet, `runtime.GOARCH` on an m1 machine returns ARM64, so the call for the update file would fail
This is required because the auto-update uses the function warning: 'openApplicationAtURL:configuration:completionHandler:' is only available on macOS 10.15 or newer [-Wunguarded-availability-new]
51cb101
to
d8e770c
Compare
Closing because the original PR has been split into smaller PRs -> https://github.com/arduino/arduino-create-agent/milestone/1?closed=1 |
Please check if the PR fulfills these requirements
before creating one)
Enhancements
What is the current behavior?
What is the new behavior?
config.ini
:config.ini
file should be created in the user folder #733)ARDUINO_CREATE_AGENT_CONFIG
additional-config.ini
needed some change as well. Now it's handled correctly but in the user dir and not in the binary folder.logs/
directory containing crash reports has been moved to user dir.embed
package to remove duplicated filesyes, docs need to be updated accordingly after the merge
Some of the commits are part of the 1.2.7-ventura release