Stricter CORS headers #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Tosatto <[email protected]>
| } | ||
| portSSL, err := getBindPort(portPlain+1, 9001) |
There was a problem hiding this comment.
You can maybe add a comment here to explain why you're passing portPlain+1. I heard people confused by it in the office. But of course if you find a free port, the previous are all occupied, and there's no reason to cycle through them again.
|
I tested it with different listening services on different ports and it works. Just add that comment and we can merge it. |
…e PR#58 Signed-off-by: Andrea Tosatto <[email protected]>
|
I've added a comment as you suggested. Maybe it's a little bit verbose, but it should clarify why I'm passing |
Signed-off-by: Andrea Tosatto <[email protected]>
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix issue #56 during the Torino HackNight contest.
The idea is basically to select a pair of free port from port-range using the
net.Listenfunction.The two ports are later used by gin to listen for incoming HTTP or HTTPS connections.