Skip to content

Make sure to add proper CORS only on the listening ports #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mastrolinux opened this issue Jan 21, 2016 · 0 comments
Open

Make sure to add proper CORS only on the listening ports #56

mastrolinux opened this issue Jan 21, 2016 · 0 comments
Assignees
@zmoog
Labels
criticality: high Of high impact type: enhancement Proposed improvement

Comments

@mastrolinux
Copy link
Contributor

mastrolinux commented Jan 21, 2016 •
edited by ArduinoBot
Loading

https://github.com/arduino/arduino-create-agent/blob/devel/main.go#L220 Right now we cycle on every port and add too many CORS headers. It will allow an attacker to run a process on localhost and use our own certificate.
@mastrolinux mastrolinux added bug type: enhancement Proposed improvement priority: high Resolution is a high priority and removed type:bug labels Jan 21, 2016
@atosatto atosatto mentioned this issue Jan 21, 2016
Merged
@zmoog zmoog self-assigned this Feb 2, 2021
@rsora rsora added criticality: high Of high impact and removed priority: high Resolution is a high priority labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmoog zmoog

Labels
criticality: high Of high impact type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zmoog @mastrolinux @rsora