CI polishing, add win64, update macOS min version #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's handy to have a reproducible environment to compile the source code
umbynos
changed the title
test.yml to release.yml and add upload artifacts
zmoog
suggested changes
Dec 14, 2020
Still to handle: TEST_TAG in test.yml and win binary name in release.yml
umbynos
force-pushed
the
umbynos/uniform_test.yml
branch
from
03fd1a8 to
3e532a0
Compare
having no fixed tags was causing the agent to autoupdate itself the first time it gets connected with create
umbynos
changed the title
test.yml to release.yml and add upload artifacts
zmoog
approved these changes
Dec 15, 2020
Comment on lines
+138
to
+153
| - name: Write gon config to file | ||
| # gon does not allow env variables in config file (https://github.com/mitchellh/gon/issues/20) | ||
| run: | | ||
| cat > gon.config.hcl <<EOF | ||
| source = ["arduino-create-agent-${{ env.RUNS_ON }}/arduino-create-agent"] | ||
| bundle_id = "cc.arduino.arduino-agent" | ||
| sign { | ||
| application_identity = "Developer ID Application: ARDUINO SA (7KT7ZWMCJT)" | ||
| } | ||
| # Ask Gon for zip output to force notarization process to take place. | ||
| # The CI will ignore the zip output, using the signed binary only. | ||
| zip { | ||
| output_path = "arduino-create-agent.zip" | ||
| } | ||
| EOF | ||
|
|
There was a problem hiding this comment.
This is a really simple and effective mechanism for templating config files, kudos!
umbynos
commented
Dec 17, 2020
| @@ -10,9 +10,17 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| operating-system: [ubuntu-18.04, windows-2019, macos-10.15] | |||
There was a problem hiding this comment.
umbynos
added a commit
that referenced
this pull request
Dec 17, 2020
* change approach: redirect stderr to file instead using defer * update gin dependency because of gin-gonic/gin#1571 * set default logger to stdout. (stderr is currently redirected to file) * save crash-report to newly created `logs/` folder * add enable/disable crash-report generation (default off) * add entry in trayicon's menu to remove crash-reports (if there are any) * CI polishing, add win64, update macOS min version (#578)
umbynos
added a commit
that referenced
this pull request
Dec 18, 2020
* change approach: redirect stderr to file instead using defer * update gin dependency because of gin-gonic/gin#1571 * set default logger to stdout. (stderr is currently redirected to file) * save crash-report to newly created `logs/` folder * add enable/disable crash-report generation (default off) * add entry in trayicon's menu to remove crash-reports (if there are any) * CI polishing, add win64, update macOS min version (#578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
CI
Align
test.ymltorelease.ymland add again upload artifacts: It's really useful to have a reproducible environment to compile the code for every platform.hardcode gon config for uniformity
Introduce win 64bit build
Change macOS min supported version to 10.11 -> change go version used to build from 1.15 to 10.14 (because of macOS)
Have
test.ymlto push artifact with0.0.0-devin order to block create auto-updateno
test.ymltorelease.ymlrevert to building minimum version for mac to 10.9 & separate step fo… #576