Skip to content

Revert "Port fix: Reinitialize serial buffer on every read to avoid concurrent rewrite" #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Dec 4, 2019

Reverts #486 due to Create Serial Monitor missing output for high serial write frequency on Arduino Uno

@rsora rsora requested review from smellai and matteosuppo December 4, 2019 13:21
@rsora rsora merged commit 318de37 into master Dec 4, 2019
@facchinm
Copy link
Member

facchinm commented Dec 4, 2019

Ehm, why? Can you add a reference to some issue/report?

@rsora
Copy link
Contributor Author

rsora commented Dec 6, 2019

@facchinm as (maybe not so clearly, I admit it 😸 ) reported in the PR description, @smellai discovered that the buffer re-initialize fix exposed another bug that happens when a board like the Uno interacts with the create serial monitor.
The bug makes thech buffer grows indefinitely (or at least this is what we read from the logs) without generating encoded data (that causes the serial monitor UI get stuck on the create frontend).
We chose to revert the fix (since the Uno is the Create most used board) and start a more focused refactoring on the func (p *serport) reader() function internals.

@umbynos umbynos deleted the revert-486-devel branch November 9, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants