Skip to content

[WE-205] sanitize paths when replacing {runtime.platform.path} #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Mar 4, 2019

This PR fixes a path generation in upload command in windows environment:

Error has this form for Arduino WiFi Rev2:
Flashing with command:C:/Users/per/.arduino-create/arduino/avrdude/6.3.0-arduino14/bin/avrdude.exe -CC:/Users/per/.arduino-create/arduino/avrdude/6.3.0-arduino14/etc/avrdude.conf -v -patmega4809 -cxplainedmini_updi -Pusb -b115200 -e -D -Uflash:w:C:/Users/per/AppData/Local/Temp/arduino-create-agent248491772/sketch_feb28a.hex:i -Ufuses:w:C:UsersperAppDataLocalTempextrafiles293253675/fuses/fuses_4809.bin:r

-Ufuses:w:C:UsersperAppDataLocalTempextrafiles293253675/fuses/fuses_4809.bin:r

should be

-Ufuses:w:C:/Users/per/AppData/Local/Temp/extrafiles293253675/fuses/fuses_4809.bin:r

this has properly tested on all 3 platforms

@rsora rsora requested a review from matteosuppo March 4, 2019 17:30
Copy link
Contributor

@matteosuppo matteosuppo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I propose to add a test for this case but for it to be effective we need to test automatically on all platforms

@matteosuppo matteosuppo merged commit 36a350f into devel Mar 5, 2019
@matteosuppo matteosuppo deleted the runtime-platform-path-fix-win branch March 5, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants