Skip to content

[WE-168] Path bugfix win #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 28, 2018
Merged

[WE-168] Path bugfix win #270

merged 7 commits into from
Nov 28, 2018

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Nov 28, 2018

This PR contains:

  • Dependency tuning for systray package for complete cross OS support (Mac OSx in particular)
  • Windows machines zip tools download issue (added testing and fixes)
  • fixed debug console html title 😸
  • little cosmetics

@rsora rsora requested a review from facchinm November 28, 2018 11:24
@rsora rsora changed the title Path bugfix win [WE-168] Path bugfix win Nov 28, 2018
facchinm
facchinm reviewed Nov 28, 2018
View reviewed changes
tools/download_test.go
t.Errorf("%v", err)
}

srcType, err := mimeType(body)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to test the internal function that takes care of format/mime type here?

facchinm
facchinm reviewed Nov 28, 2018
View reviewed changes
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the extractor test everything looks fine 😄

@facchinm facchinm merged commit eeba2ce into devel Nov 28, 2018
@umbynos umbynos deleted the path_bugfix_win branch November 9, 2020 17:43
@umbynos umbynos mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsora @facchinm