[WE-19] Deploy configuration overhaul and support for proxies #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanno Braun <[email protected]>
Eliminated iniflags, used a flagset to handle inheritance of config. Changing config restarts the process (so that it can be instantiated again)
Handle config better
The trayicon is displayed as soon as possible, in a goroutine. A select is used to block forever (before it was the trayicon that did it)
Prevent delays from displaying the trayicon
The flag parser was confused with flags separated by spaces, resulting in inconsistent behaviour where flags were discarded
Add configuration setting to set proxy server
rsora
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.