Fix tool download on 64-bit Windows #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling the agent on 64-bit Windows, tool downloads fail, as no 64-bit Windows builds of the tools are available (as far as I can tell). This commit directs agents compiled for 64-bit Windows to just download the 32-bit Windows variant of the tool. Signed-off-by: Hanno Braun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the agent on 64-bit Windows, tool downloads fail, as no
64-bit Windows builds of the tools are available (as far as I can tell).
This commit directs agents compiled for 64-bit Windows to just download
the 32-bit Windows variant of the tool.
Please note that while I have confirmed that this fix works for me (by successfully downloading bossac and uploading a program to my Arduino Due), I'm not sure if there are any side-effects of this change that I'm not aware of. Please let me know if there's anything wrong with this pull request.
Close #199.