Skip to content

V2 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 5, 2019
Merged

V2 #109

merged 13 commits into from
Apr 5, 2019

Conversation

matteosuppo
Copy link
Contributor

No description provided.

@matteosuppo matteosuppo marked this pull request as ready for review April 4, 2019 08:47
@matteosuppo matteosuppo requested a review from smellai April 4, 2019 08:47
demo/app.jsx Outdated
@@ -173,11 +174,11 @@ class App extends React.Component {
{device.Name} - IsOpen: <span className={device.IsOpen ? 'open' : 'closed'}>
{device.IsOpen ? 'true' : 'false'}
</span> - <a href="#" onClick={(e) => this.handleOpen(e, device.Name)}>
open
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteosuppo pleeease, don't modify the formatting 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry vscode decided it was better that way. I didn't even notice. Should I put it the way it was?

Copy link
Contributor

@AlbyIanna AlbyIanna Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, vscode has its own will sometimes. Yes please 👍

@AlbyIanna
Copy link
Contributor

looks good to me

@smellai smellai merged commit 4c1af7c into master Apr 5, 2019
@smellai smellai deleted the v2 branch April 5, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants