Skip to content

Fix config mapstructure tag #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix config mapstructure tag #98

merged 1 commit into from
Feb 23, 2022

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Feb 18, 2022

Motivation

Config tags were wrong. The correct form is mapstructure.
This tag is used to support all the file extension known by viper. (we use json and yaml)

Change description

fix mapstructure tags

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested review from eclipse1985 and rsora February 18, 2022 12:02
Copy link

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@polldo polldo merged commit 350248c into main Feb 23, 2022
@polldo polldo deleted the polldo/fix-config-tag branch February 23, 2022 11:10
polldo added a commit that referenced this pull request Sep 2, 2022
Config tags were wrong. The correct form is `mapstructure`.
This tag is used to support all the file extension known by viper. (we use json and yaml)
polldo added a commit that referenced this pull request Sep 2, 2022
Config tags were wrong. The correct form is `mapstructure`.
This tag is used to support all the file extension known by viper. (we use json and yaml)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants