-
-
Notifications
You must be signed in to change notification settings - Fork 4
Implement lzss encoder #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@polldo did you create the .lzss files using Alex's implementation? |
@zmoog I generated them directly using the C implementation |
Great. This is the way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @polldo can you please perform an OTA test?
@eclipse1985 I've already tested it on linux, are you able to test it on macos? |
Tested, works for me 🚀 |
Added a pure go implementation of the lzss encoding algorithm used by iot cloud to compress ota files. This allows to get rid of cgo.
Added a pure go implementation of the lzss encoding algorithm used by iot cloud to compress ota files. This allows to get rid of cgo.
Motivation
we want to avoid cgo, so we need a pure go implementation of the lzss encoding algorithm used by iot cloud
Change description
Additional Notes
Reviewer checklist
main
.CONTRIBUTING.md
) and are well formatted.