Refactor config in credentials #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclipse1985
approved these changes
Dec 21, 2021
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
We want the configuration split in two files: 'arduino-cloud.yaml' and 'arduino-cloud-credentials.yaml' They will have two separate commands: 'arduino-cloud-cli config' and 'arduino-cloud-cli credentials' At the moment only credentials have been added, but in the future we could add a config with these params: url endpoint; output format; verbose; breaking change: 'config' command is now changed into 'credentials'
polldo
pushed a commit
that referenced
this pull request
Sep 2, 2022
We want the configuration split in two files: 'arduino-cloud.yaml' and 'arduino-cloud-credentials.yaml' They will have two separate commands: 'arduino-cloud-cli config' and 'arduino-cloud-cli credentials' At the moment only credentials have been added, but in the future we could add a config with these params: url endpoint; output format; verbose; breaking change: 'config' command is now changed into 'credentials'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want the configuration split in two files:
arduino-cloud.yamlandarduino-cloud-credentials.yamlThey will have two separate commands:
arduino-cloud-cli configandarduino-cloud-cli credentialsAt the moment only credentials have been added, but in the future we could add a config with these params:
Change description
Additional Notes
Reviewer checklist
main.CONTRIBUTING.md) and are well formatted.