Skip to content

Upgrade arduino-cli #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 20, 2021
Merged

Upgrade arduino-cli #88

merged 8 commits into from
Dec 20, 2021

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Dec 16, 2021

Motivation

arduino-cli dependency needs to be upgraded. Several breaking changes have been introduced

Change description

update arduino-cli dependency
adapt to the breaking changes:

  • new way to create instance
  • board list command requires a request param now
  • upload command requires both the address and protocol of the serial port.

Additional Notes

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@polldo polldo requested review from glumia and eclipse1985 December 16, 2021 11:12
@polldo polldo force-pushed the polldo/arduino-cli-update branch from de87ca1 to c7603f5 Compare December 20, 2021 15:04
@polldo polldo merged commit 24b4410 into main Dec 20, 2021
@polldo polldo deleted the polldo/arduino-cli-update branch December 20, 2021 15:19
polldo pushed a commit that referenced this pull request Sep 2, 2022
Update arduino-cli dependency and adapt to its breaking changes:
- new way to create instance
- board list command requires a request param with a timeout
- upload command requires both the address and protocol of the serial port.
polldo pushed a commit that referenced this pull request Sep 2, 2022
Update arduino-cli dependency and adapt to its breaking changes:
- new way to create instance
- board list command requires a request param with a timeout
- upload command requires both the address and protocol of the serial port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants